chore(examples): use Material 3 in example applications #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
force-pushed
the
@kkafar/use-material-3-in-examples
branch
from
7e1b582
to
4668c3c
Compare
11 tasks
tboba
approved these changes
Jun 24, 2024
| @@ -132,6 +132,8 @@ dependencies { | |||
| } else { | |||
| implementation jscFlavor | |||
| } | |||
|
|
|||
| implementation("com.google.android.material:material:1.9.0") | |||
There was a problem hiding this comment.
I'm worried if anyone that will try to install the Example app on Android will stumble upon the issue with too low version of Kotlin. Should we maybe add some comment here or create a README with prerequisites to install the app?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up review discussion:
to PR
This PR introduces usage of Material 3 in our example applications, so that it is easier to test new Sheets & top app bar APIs.
The 1.9.0 version was chosen, because:
appcompat&activitylibs, which are known to be problematic with updates (we already had some issues in the past related to that)Changes
Test code and steps to reproduce
Application should work as normal & Material 3 components should be used.
Checklist