Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Group benchmarks into suites #942

Open
wants to merge 22 commits into
base: release
Choose a base branch
from
Open

docs: Group benchmarks into suites #942

wants to merge 22 commits into from
+522 −268

Conversation

aleksanderkatan
Copy link
Collaborator

@aleksanderkatan aleksanderkatan commented Feb 24, 2025 •
edited
Loading

Closes #898

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 24, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@942
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@d576e163aaeb7aaefcd985df50cc8223a760d994

benchmark
view benchmark

commit
view commit

@aleksanderkatan
Copy link
Collaborator Author

Sometimes, the Run Benchmarks button does not cause the BenchmarkFallback and BenchmarkResults to visually appear, although the benchmarks still run. This might be an nr issue, since restarting the dev environment seems to temporarily fix the problem.

@aleksanderkatan aleksanderkatan marked this pull request as ready for review February 25, 2025 12:50
mhawryluk
mhawryluk reviewed Feb 25, 2025
View reviewed changes
apps/typegpu-docs/src/pages/benchmark/benchmark-app.tsx Outdated
@@ -306,6 +102,17 @@ export default function BenchmarkApp() {
<CirclePlus />
</button>
</div>
<p className="w-full mt-1 mb-3 text-lg">Benchmark suites to run:</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd give more top margin here. or preferably wrap the two sections (versions and suites) in divs and space them using gap on parent element

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the margins to gap on parent element

Aleksander Katan and others added 17 commits February 26, 2025 16:08
@aleksanderkatan aleksanderkatan force-pushed the docs/group-benchmarks-into-suites branch from 3020751 to 1f924c4 Compare February 26, 2025 15:08
@aleksanderkatan aleksanderkatan linked an issue Feb 26, 2025 that may be closed by this pull request
docs: Group benchmarks into "suites", and allow users to pick which suites they want to run #898
Open
reczkok
reczkok approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Great addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reczkok reczkok reczkok approved these changes

@iwoplaza iwoplaza Awaiting requested review from iwoplaza

@mhawryluk mhawryluk Awaiting requested review from mhawryluk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Group benchmarks into "suites", and allow users to pick which suites they want to run
3 participants
@aleksanderkatan @reczkok @mhawryluk