fix: run next middleware of fail (nack) #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindhells
commented
Feb 11, 2025
| @@ -50,6 +53,7 @@ services: | |||
| volumes: | |||
| - shared_socket:/tmp | |||
| image: softonic/hp-pass-middleware:dev | |||
| user: root | |||
| environment: | |||
| IN_SOCKET: "/tmp/res2" | |||
| command: ["-stderrthreshold=INFO"] | |||
There was a problem hiding this comment.
I had to use root in order for docker-compose to work, as the default user for the images is now 1000:1000
josemanuel-cardona
approved these changes
Feb 18, 2025
joskfg
approved these changes
Feb 18, 2025
joskfg
reviewed
Feb 18, 2025
| @@ -55,7 +55,14 @@ func (ew *Writer) timeout(ackChannel chan<- messages.Message) { | |||
| func (ew *Writer) trigger(ackChannel chan<- messages.Message) { | |||
| ew.mutex.Lock() | |||
|
|
|||
| ew.WriteAdapter.ProcessMessages(&ew.msgs) | |||
| // filter out messages explicitly n-acked | |||
There was a problem hiding this comment.
Interesting new usage for nack/ack that can be done due to the latest change done from @paupm. I didn't realize this possible usage then.
There was a problem hiding this comment.
This nack messages come from a failing middleware, right?
It can also be possible that the middleware works but it nack specific messages for some reason?
There was a problem hiding this comment.
the middleware itself does not have control over the messages to nack them, does it?
Only the adapters do as far as I can tell 🤔 (elastic)... and now the middleware manager
paupm
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix middleware pattern: unexpected behaviour
Next middleware should be executed correctly of the message is discarded (nack)