Migrate tests to use python scripts instead of rust test helper #210
+107
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to get rid of the
test_executables_helper
in favor of specifying test programs in python. This has some advantages:match
statement insrc/test_executables/helper.rs
.rust-script
, even when the compilation artifacts are already cached.test_executables_helper
and thetest_executables
feature inCargo.toml
. I think these details ideally shouldn't be in that file.bitflags
dependency. Not sure though.There's also some disadvantages:
python3
to execute the tests. Fortunately, that is installed on lots of systems. For example to make this PR run on CI, I didn't have to install anything there.