Switch to async io to avoid spawning three OS threads per command #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soenkehahn
force-pushed
the
async
branch
7 times, most recently
from
174f3cb to
7c8dc8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR
cradlespawns 3 OS threads (withstd::thread::spawn) per executed child process. These are used to write tostdinand read fromstderrandstdout. This PR switches to usingtokioand async io. This may be good, since -- at least on linux -- OS threads are not super efficient.This is currently just a WIP PR.
One open question: Can we even start a
tokioruntime without destroying the ability of library users to use async runtimes themselves?