Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1524221 handle nested arrays #1176

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

SNOW-1524221 handle nested arrays #1176

wants to merge 3 commits into from
+40 −0

Conversation

sfc-gh-astachowski
Copy link
Contributor

Description

SNOW-1524221 Added handling of N-dimensional arrays for N>2 to stringToValue

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-astachowski sfc-gh-astachowski requested a review from a team as a code owner July 9, 2024 11:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sfc-gh-astachowski sfc-gh-astachowski marked this pull request as draft July 9, 2024 11:03
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (52590b9) to head (112ffe8).
Report is 2 commits behind head on master.

Files Patch % Lines
converter.go 77.77% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
- Coverage   83.16%   83.16%   -0.01%     
==========================================
  Files          54       54              
  Lines       12149    12158       +9     
==========================================
+ Hits        10104    10111       +7     
- Misses       2045     2047       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sfc-gh-pfus
sfc-gh-pfus reviewed Jul 9, 2024
View reviewed changes
converter_test.go
@@ -363,6 +363,30 @@ func TestStringToValue(t *testing.T) {
} else if ts.UnixNano() != 1549491451123456789 {
t.Errorf("expected unix timestamp: 1549491451123456789, got %v", ts.UnixNano())
}

rowType = &execResponseRowType{Type: "array", Fields: []fieldMetadata{{Type: "array", Fields: []fieldMetadata{{Type: "fixed"}}}}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a E2E test as well (in structured_types_read.go)? How does it relate to TestArrayOfArrays?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, added a case in TestArrayOfArrays for a 3-dimensional array. Currently native arrow fails it, I'm working on that as well

@sfc-gh-astachowski
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-astachowski
Copy link
Contributor Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-astachowski @sfc-gh-pfus