-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed action_date
in action_logs
#16469
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
PR Summary
|
Signed-off-by: snipe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏾
'activity_report' => 'Activity Report', | ||
'address' => 'Address', | ||
'admin' => 'Admin Settings', | ||
'admin_user' => 'Admin User', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this one is actually used?
This should fix an issue where we were not always including an
action_date
in theaction_logs
table, which meant that sorting by date could get a little confusing in history, since every item has acreated_at
, butaction_date
was meant to be an override in case the action "really" happened in the past or future. We always want to record the actual date the action was recorded, but also wanted to display the date the action was taken, which could sometimes be different.This also adds a boot method to make sure that action date is correctly recorded on every
action_log
entry, and adds an index to theaction_date
since it's something that is likely to be searched on or sorted on.I do know @uberbrady is working on a refactor of the logging system, so parts of this change might be subsumed or replaced when his PR is ready, but this solves the immediate problem.