Improved wording in asset checkout emails #16446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That table renders horribly but should get the point across... |
snipe
reviewed
Mar 11, 2025
| @@ -74,7 +74,7 @@ public function content(): Content | |||
| { | |||
| $this->item->load('assetstatus'); | |||
| $eula = method_exists($this->item, 'getEula') ? $this->item->getEula() : ''; | |||
| $req_accept = method_exists($this->item, 'requireAcceptance') ? $this->item->requireAcceptance() : 0; | |||
| $req_accept = $this->requiresAcceptance(); | |||
There was a problem hiding this comment.
Are we sure we want to change this? I think this was there for checkout to location, other assets, etc.
There was a problem hiding this comment.
@snipe Double-check me but the old line is pulled as is into the private method so I can call it repeatedly in the introductionLine() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the wording of the subject line and introduction text for asset checkout emails and reminders to improve clarity around the user needing potentially needing to take an action (accepting the asset).
Text changed to signify an asset was "recently" checked out to them