Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16331 - Don't make passport:install command require user input #16341

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

uberbrady
Copy link
Collaborator

At some point, php artisan passport:install started to require some level of user-input in order to function - and this isn't going to at all work well when it's being run via Artisan::call() - which is in a web-context. PHP docs explicitly mention that STDIN is only defined when running in a command-line context, which we definitely are not doing in a web GUI context.

This change just adds a --no-interaction flag to the Passport artisan command so it won't get hung up looking for user input on STDIN.

I tested on my local on a blank database and this did, actually, seem to wwork.

@uberbrady uberbrady requested a review from snipe as a code owner February 25, 2025 16:41
Copy link

what-the-diff bot commented Feb 25, 2025

PR Summary

  • Modified the passport installation command
    This update has tweaked the command to install passport, which is a critical component for authentication in our software. This will now include a --no-interaction flag, reducing the need for manual intervention during installation. This simplifies the installation process, making it more streamlined and user-friendly.

@snipe
Copy link
Owner

snipe commented Feb 25, 2025

This looks great, ty!

@snipe snipe merged commit 037d2d9 into snipe:develop Feb 25, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants