Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #16334 - Changed composer order in upgrade script #16336

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

snipe
Copy link
Owner

@snipe snipe commented Feb 25, 2025

This should fix #16334, where the backup would fail since the new dependences have not yet been installed.

@snipe snipe requested a review from uberbrady February 25, 2025 12:06
Copy link

what-the-diff bot commented Feb 25, 2025

PR Summary

  • Introduces Pre-Migration Backup
    The update adds a significant new step to ensure a backup is created before the process of data transfer begins. This change will serve to protect valuable data during migration, providing an additional safety net.

  • Rationalizes Upgrade Process
    Renumbering of steps within the script reflects a more logical order of operations. By executing the 'Backing up database' operation as part of step 8 and relegating 'Putting application into maintenance mode' to step 7, we've maximized operational efficiency.

  • Eliminates Redundancies
    To minimize confusion, the revised script removes echo commands that were previously duplicated. These pertained to operations for backing up the database and transitioning the application into maintenance mode. The improvements will enhance readability and comprehension for users.

@snipe
Copy link
Owner Author

snipe commented Feb 25, 2025

"By executing the 'Backing up database' operation as part of step 8 and relegating 'Putting application into maintenance mode' to step 7, we've maximized operational efficiency."

lol oh AI...

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think I was getting 'stuck' on the "backup-before-pull" concept, but the backup doesn't backup vendors or the actual application code itself; just the data - so we really don't need to do it in that order. Thank you!

@snipe snipe merged commit 18c7cbb into develop Feb 25, 2025
9 checks passed
@snipe snipe deleted the change_order_in_upgrade_script branch February 25, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants