Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid locking JARs on Windows when opening input streams #2049

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

aloubyansky
Copy link
Member

This may help with quarkusio/quarkus#43940
Needs to be confirmed by testing on Windows.

@MikeEdgar
Copy link
Member

Thanks @aloubyansky, I'm doing something almost the same with the methods copied from io.quarkus.runtime.util.ClassPathUtils. I'll update the group on the Quarkus issue.

@aloubyansky
Copy link
Member Author

Just fyi, io.smallrye.common.classloader.ClassPathUtils (which is a copy of the Quarkus class) is available in this project.

@MikeEdgar
Copy link
Member

Just fyi, io.smallrye.common.classloader.ClassPathUtils (which is a copy of the Quarkus class) is available in this project.

Perfect, I'll use that instead.

@MikeEdgar MikeEdgar requested a review from a team as a code owner October 30, 2024 10:44
@MikeEdgar MikeEdgar changed the base branch from 3.x to main October 30, 2024 10:44
@MikeEdgar
Copy link
Member

I incorporated the smallrye-common class utility and consolidated some code around reading the static files. This will go to main and I'll backport to 3.x for the LTS.

MikeEdgar
MikeEdgar previously approved these changes Oct 30, 2024
@MikeEdgar MikeEdgar added this to the 4.0.1 milestone Oct 30, 2024
@MikeEdgar MikeEdgar added the backport/3.x Issue pending backport to the 3.x series label Oct 30, 2024
@MikeEdgar MikeEdgar closed this Oct 30, 2024
@MikeEdgar MikeEdgar reopened this Oct 30, 2024
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
70.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@MikeEdgar
Copy link
Member

I'll go ahead and merge this. I'm not worried about the coverage warning as it's catch blocks for IO errors that are re-thrown and deprecated code.

@MikeEdgar MikeEdgar merged commit 5f830ff into smallrye:main Oct 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/3.x Issue pending backport to the 3.x series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants