Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve popover implementation to match standards effort #491

Merged
merged 22 commits into from
Jul 3, 2023
Merged

Conversation

jpzwarte
Copy link
Member

@jpzwarte jpzwarte commented Jun 30, 2023

Fixes #466

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: cf22628

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@sl-design-system/shared Patch
@sl-design-system/text-input Patch
@sl-design-system/textarea Patch
@sl-design-system/popover Patch
@sl-design-system/tooltip Patch
@sl-design-system/select Patch
@sl-design-system/button Patch
@sl-design-system/checkbox Patch
@sl-design-system/editor Patch
@sl-design-system/grid Patch
@sl-design-system/radio-group Patch
@sl-design-system/tabs Patch
@sl-design-system/label Patch
@sl-design-system/drawer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

🕸 Website preview

You can view a preview here (commit cf226286b11afd9c65f472500b8c680beaab487d).

@jpzwarte jpzwarte requested a review from Diaan July 3, 2023 09:15
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

🕸 Storybook preview

You can view a preview here (commit cf226286b11afd9c65f472500b8c680beaab487d).

@jpzwarte jpzwarte merged commit d7f7af8 into main Jul 3, 2023
@jpzwarte jpzwarte deleted the fix/popover branch July 3, 2023 12:40
@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align <sl-popover> implementation with the popover standard
2 participants