Merge pull request #651 from skydoves/fix/crossfade-state

Fix instability of the crossfade plugin
skydoves · Feb 17, 2025 · 9182dbd · 9182dbd
2 parents b36445f + b023570
commit 9182dbd
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/.../commonMain/kotlin/com/skydoves/landscapist/animation/circular/CircularRevealAnimation.kt b/.../commonMain/kotlin/com/skydoves/landscapist/animation/circular/CircularRevealAnimation.kt
@@ -19,7 +19,6 @@ import androidx.compose.animation.core.MutableTransitionState
 import androidx.compose.animation.core.animateFloat
 import androidx.compose.animation.core.rememberTransition
 import androidx.compose.animation.core.tween
-import androidx.compose.animation.core.updateTransition
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.remember

diff --git a/.../src/commonMain/kotlin/com/skydoves/landscapist/animation/crossfade/CrossfadeAnimation.kt b/.../src/commonMain/kotlin/com/skydoves/landscapist/animation/crossfade/CrossfadeAnimation.kt
@@ -35,7 +35,7 @@ internal fun Painter.rememberCrossfadePainter(
   durationMs: Int,
 ): Painter {
   val size = Size(imageBitmap.width.toFloat(), imageBitmap.height.toFloat())
-  val colorMatrix = remember { ColorMatrix() }
+  val colorMatrix = remember(imageBitmap) { ColorMatrix() }
   val fadeInTransition = updateFadeInTransition(key = size, durationMs = durationMs)
   val transitionColorFilter = if (!fadeInTransition.isFinished) {
     colorMatrix.apply {

diff --git a/...ion/src/commonMain/kotlin/com/skydoves/landscapist/animation/crossfade/CrossfadePlugin.kt b/...ion/src/commonMain/kotlin/com/skydoves/landscapist/animation/crossfade/CrossfadePlugin.kt
@@ -29,7 +29,7 @@ import com.skydoves.landscapist.plugins.ImagePlugin
  */
 @Immutable
 public class CrossfadePlugin(
-  private val duration: Int = 550,
+  private val duration: Int = 250,
 ) : ImagePlugin.PainterPlugin {
 
   @Composable