react-router-issue

This monorepo was created to help log a github issue:

• remix-run/react-router#13091

It contains 2 packages/apps created in different ways: one with remix v2, and one with react-router v7.

The steps I took were:

cd packages;
npx create-remix@latest remix-app
npx create-react-router@latest react-router-app

(see remix docs and react-router docs)

After that I made vite.config.ts changes to both apps:

  build: {
    rollupOptions: {
      // https://vitejs.dev/config/build-options.html#build-rollupoptions
      output: {
        // https://rollupjs.org/configuration-options/#output-assetfilenames
        assetFileNames: 'myapp-assets/myapp-[name]-[hash][extname]',
        // https://rollupjs.org/configuration-options/#output-chunkfilenames
        chunkFileNames: 'myapp-chunks/myapp-[name]-[hash].js',
        // https://rollupjs.org/configuration-options/#output-entryfilenames
        entryFileNames: 'myapp-entries/myapp-[name]-[hash].js',
      },
    },
  },

and I set ssr: false in the respective framework configs.

After building both apps, the build folder output is not what I would expect. In react-router v7, my route files are showing up in assets (and not in the rollup entry folder that I configured).

viewing build output

You can view the different build output in the builds folder, or on github at:

• https://github.com/skratchdot/react-router-issue/tree/main/builds

getting started

git clone [email protected]:skratchdot/react-router-issue.git
cd react-router-issue
pnpm install
pnpm build

you can also run both apps via:

pnpm dev

the fix

When version 7.3.0 was published, the issue was fixed. You can see the update in this repo by viewing the following commit (which updates from v7.2.0 to v7.3.0):

• https://github.com/skratchdot/react-router-issue/commit/aadf4d8275b037020bcc97f6bef8587bef1947e6