Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skos.shacl.ttl : sh namespace error and missing skos prefix #24

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

EmidioStani
Copy link
Contributor

it solves the issue "The values of sh:namespace are literals of datatype xsd:anyURI" see: w3c/data-shapes#125

and added the skos: prefix for 1 rule

@acka47
Copy link
Member

acka47 commented Sep 9, 2024

+1 Looks good to me. However, I was not aware of the issue that this fixes and validation with Jena (e.g. shacl validate -s skos.shacl.ttl -d tests/valid/skos.shacl.ttl/ex24.tt) has the same result with and without this commit.

@EmidioStani
Copy link
Contributor Author

I have tested with the ITB SHACL Shapes validator on level 2 (extended W3C rules).

I guess there are some assumptions made by the validators.

@sroertgen
Copy link
Contributor

Thank you! Will have a look!

@sroertgen
Copy link
Contributor

LGTM

Thank you! 🙏

Just out of curiosity: In what kind of context are you using SKOS / SkoHub Shapes?

@sroertgen sroertgen merged commit 1a90b44 into skohub-io:main Sep 17, 2024
@EmidioStani
Copy link
Contributor Author

@sroertgen I am designing the data model of a taxonomy for a client based on skos and I remembered that you @sroertgen were asking on twitter about it. So I am using skos shapes (slightly modified with recommendations from ITB Shacl Shapes Validator + identifiers within message) to make sure that data model is compliant with SKOS, plus additional shapes coming from the data model (e.g additional proprerties, regex on labels, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants