Out of gas stuck escrow fee

[freeelancer]

If transactions are included in the block but goes out of gas, escrowed fees become stuck in the feemarket-fee-collector. This PR attempts to fix this by distributing the fees (based on the param.DistributeFees) through subsequent transactions in the posthandler.

[aljo242]

Hey @freeelancer thanks for opening this PR!

I see a few issues with the current implementation of this:

• The query is calling GetAllBalances() for the fee market module account. This works in the isolated scenario shown, but I think this will have issues as is. For example, if params.DistributeFees == false for 10 blocks and some transactions run, the module account will accumulate fees. All of these fees will be distributed upon our failed transaction, when it should only be the amount that was escrowed.
• I'm not sure if the provided test is reproducing an actual issue here. This test is causing out of gas to be called in the ante handler, in which case this transaction should never be included into a block and the state commitment is to the CheckTx commitment tree.
• Transactions that are included in the block, but run of out gas will be guaranteed to at least pass the anteHandler. If they run out of gas during message processing, the post handler will always be run for them.

Is this an issue you ran into during some testing or with integration into a chain?

[aljo242]

we're not necessarily dealing with stuck fees every time this code is run