Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/841 Improve Sgx Related Logs #858

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Enhancement/841 Improve Sgx Related Logs #858

merged 1 commit into from
Feb 6, 2025

Conversation

PropzSaladaz
Copy link
Contributor

Description

Added logs on libconsensus side to print errors returned from sgx server.

Tests

  • Tested changing ecdsaKeyName,and keyShareName for errors relative to fetching non-existent keys.
  • Tested changing the bls keys, but there were already error loggers on these.

Fixes #841

Note

This pr is replicate from a closed pr that included non-signed commits: #857

@PropzSaladaz PropzSaladaz added the enhancement New feature or request label Feb 5, 2025
@PropzSaladaz PropzSaladaz self-assigned this Feb 5, 2025
@PropzSaladaz PropzSaladaz merged commit 8d3d474 into develop Feb 6, 2025
4 checks passed
@PropzSaladaz PropzSaladaz deleted the enhancement/841-improve-related-logs-2 branch February 6, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olehnikolaiev olehnikolaiev olehnikolaiev approved these changes

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Assignees

@PropzSaladaz PropzSaladaz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more informative SGX related logs
2 participants
@PropzSaladaz @olehnikolaiev