Skip to content

Bump solhint from 3.4.1 to 5.0.4 #2909

Bump solhint from 3.4.1 to 5.0.4

Bump solhint from 3.4.1 to 5.0.4 #2909

Triggered via push January 9, 2025 15:55
Status Failure
Total duration 53s
Artifacts

test.yml

on: push
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

34 errors and 84 warnings
test (18.x, 3.10.x): contracts/Marionette.sol#L69
Function order is incorrect, constructor/initializer can not go after receive function (line 65)
test (18.x, 3.10.x)
Process completed with exit code 1.
test (18.x, 3.8.x): contracts/Marionette.sol#L69
Function order is incorrect, constructor/initializer can not go after receive function (line 65)
test (18.x, 3.8.x)
Process completed with exit code 1.
test (18.x, 3.11.x): contracts/Marionette.sol#L69
Function order is incorrect, constructor/initializer can not go after receive function (line 65)
test (22.x, 3.11.x): contracts/Marionette.sol#L69
Function order is incorrect, constructor/initializer can not go after receive function (line 65)
test (18.x, 3.11.x)
Process completed with exit code 1.
test (22.x, 3.11.x)
Process completed with exit code 1.
test (20.x, 3.11.x)
The job was canceled because "_18_x_3_10_x" failed.
test (20.x, 3.11.x): contracts/Marionette.sol#L69
Function order is incorrect, constructor/initializer can not go after receive function (line 65)
test (20.x, 3.11.x)
Process completed with exit code 1.
test (22.x, 3.12.x)
The job was canceled because "_18_x_3_10_x" failed.
test (22.x, 3.12.x): contracts/Marionette.sol#L69
Function order is incorrect, constructor/initializer can not go after receive function (line 65)
test (22.x, 3.12.x)
Process completed with exit code 1.
test (20.x, 3.8.x)
The job was canceled because "_18_x_3_10_x" failed.
test (20.x, 3.8.x)
The operation was canceled.
test (22.x, 3.10.x)
The job was canceled because "_18_x_3_10_x" failed.
test (18.x, 3.9.x)
The job was canceled because "_18_x_3_10_x" failed.
test (18.x, 3.9.x)
The operation was canceled.
test (22.x, 3.10.x): contracts/Marionette.sol#L69
Function order is incorrect, constructor/initializer can not go after receive function (line 65)
test (22.x, 3.10.x)
Process completed with exit code 1.
test (20.x, 3.10.x)
The job was canceled because "_18_x_3_10_x" failed.
test (20.x, 3.10.x)
The operation was canceled.
test (20.x, 3.9.x)
The job was canceled because "_18_x_3_10_x" failed.
test (20.x, 3.9.x): contracts/Marionette.sol#L69
Function order is incorrect, constructor/initializer can not go after receive function (line 65)
test (20.x, 3.9.x)
The operation was canceled.
test (20.x, 3.12.x)
The job was canceled because "_18_x_3_10_x" failed.
test (20.x, 3.12.x)
The operation was canceled.
test (18.x, 3.12.x)
The job was canceled because "_18_x_3_10_x" failed.
test (18.x, 3.12.x)
The operation was canceled.
test (22.x, 3.9.x)
The job was canceled because "_18_x_3_10_x" failed.
test (22.x, 3.9.x)
The operation was canceled.
test (22.x, 3.8.x)
The job was canceled because "_18_x_3_10_x" failed.
test (22.x, 3.8.x)
The operation was canceled.
test (18.x, 3.10.x)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test (18.x, 3.10.x): contracts/Marionette.sol#L44
GC: [sender] on Event [EtherReceived] could be Indexed
test (18.x, 3.10.x): contracts/Marionette.sol#L44
GC: [amount] on Event [EtherReceived] could be Indexed
test (18.x, 3.10.x): contracts/Marionette.sol#L46
Rule is set with explicit type [var/s: uint]
test (18.x, 3.10.x): contracts/Marionette.sol#L49
GC: [receiver] on Event [EtherSent] could be Indexed
test (18.x, 3.10.x): contracts/Marionette.sol#L49
GC: [amount] on Event [EtherSent] could be Indexed
test (18.x, 3.10.x): contracts/Marionette.sol#L51
Rule is set with explicit type [var/s: uint]
test (18.x, 3.10.x): contracts/Marionette.sol#L69
Function initialize() must match Foundry test naming convention
test (18.x, 3.10.x): contracts/Marionette.sol#L78
Function postMessage() must match Foundry test naming convention
test (18.x, 3.10.x): contracts/Marionette.sol#L86
GC: Use Custom Errors instead of require statements
test (18.x, 3.10.x): contracts/Marionette.sol#L87
GC: Use Custom Errors instead of require statements
test (18.x, 3.8.x)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test (18.x, 3.8.x): contracts/Marionette.sol#L44
GC: [sender] on Event [EtherReceived] could be Indexed
test (18.x, 3.8.x): contracts/Marionette.sol#L44
GC: [amount] on Event [EtherReceived] could be Indexed
test (18.x, 3.8.x): contracts/Marionette.sol#L46
Rule is set with explicit type [var/s: uint]
test (18.x, 3.8.x): contracts/Marionette.sol#L49
GC: [receiver] on Event [EtherSent] could be Indexed
test (18.x, 3.8.x): contracts/Marionette.sol#L49
GC: [amount] on Event [EtherSent] could be Indexed
test (18.x, 3.8.x): contracts/Marionette.sol#L51
Rule is set with explicit type [var/s: uint]
test (18.x, 3.8.x): contracts/Marionette.sol#L69
Function initialize() must match Foundry test naming convention
test (18.x, 3.8.x): contracts/Marionette.sol#L78
Function postMessage() must match Foundry test naming convention
test (18.x, 3.8.x): contracts/Marionette.sol#L86
GC: Use Custom Errors instead of require statements
test (18.x, 3.8.x): contracts/Marionette.sol#L87
GC: Use Custom Errors instead of require statements
test (18.x, 3.11.x)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test (18.x, 3.11.x): contracts/Marionette.sol#L44
GC: [sender] on Event [EtherReceived] could be Indexed
test (22.x, 3.11.x)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test (18.x, 3.11.x): contracts/Marionette.sol#L44
GC: [amount] on Event [EtherReceived] could be Indexed
test (22.x, 3.11.x): contracts/Marionette.sol#L44
GC: [sender] on Event [EtherReceived] could be Indexed
test (18.x, 3.11.x): contracts/Marionette.sol#L46
Rule is set with explicit type [var/s: uint]
test (22.x, 3.11.x): contracts/Marionette.sol#L44
GC: [amount] on Event [EtherReceived] could be Indexed
test (18.x, 3.11.x): contracts/Marionette.sol#L49
GC: [receiver] on Event [EtherSent] could be Indexed
test (22.x, 3.11.x): contracts/Marionette.sol#L46
Rule is set with explicit type [var/s: uint]
test (18.x, 3.11.x): contracts/Marionette.sol#L49
GC: [amount] on Event [EtherSent] could be Indexed
test (22.x, 3.11.x): contracts/Marionette.sol#L49
GC: [receiver] on Event [EtherSent] could be Indexed
test (18.x, 3.11.x): contracts/Marionette.sol#L51
Rule is set with explicit type [var/s: uint]
test (22.x, 3.11.x): contracts/Marionette.sol#L49
GC: [amount] on Event [EtherSent] could be Indexed
test (22.x, 3.11.x): contracts/Marionette.sol#L51
Rule is set with explicit type [var/s: uint]
test (18.x, 3.11.x): contracts/Marionette.sol#L69
Function initialize() must match Foundry test naming convention
test (18.x, 3.11.x): contracts/Marionette.sol#L78
Function postMessage() must match Foundry test naming convention
test (22.x, 3.11.x): contracts/Marionette.sol#L69
Function initialize() must match Foundry test naming convention
test (18.x, 3.11.x): contracts/Marionette.sol#L86
GC: Use Custom Errors instead of require statements
test (22.x, 3.11.x): contracts/Marionette.sol#L78
Function postMessage() must match Foundry test naming convention
test (18.x, 3.11.x): contracts/Marionette.sol#L87
GC: Use Custom Errors instead of require statements
test (22.x, 3.11.x): contracts/Marionette.sol#L86
GC: Use Custom Errors instead of require statements
test (22.x, 3.11.x): contracts/Marionette.sol#L87
GC: Use Custom Errors instead of require statements
test (20.x, 3.11.x): contracts/Marionette.sol#L44
GC: [sender] on Event [EtherReceived] could be Indexed
test (20.x, 3.11.x): contracts/Marionette.sol#L44
GC: [amount] on Event [EtherReceived] could be Indexed
test (20.x, 3.11.x): contracts/Marionette.sol#L46
Rule is set with explicit type [var/s: uint]
test (20.x, 3.11.x): contracts/Marionette.sol#L49
GC: [receiver] on Event [EtherSent] could be Indexed
test (20.x, 3.11.x): contracts/Marionette.sol#L49
GC: [amount] on Event [EtherSent] could be Indexed
test (20.x, 3.11.x): contracts/Marionette.sol#L51
Rule is set with explicit type [var/s: uint]
test (20.x, 3.11.x): contracts/Marionette.sol#L69
Function initialize() must match Foundry test naming convention
test (20.x, 3.11.x): contracts/Marionette.sol#L78
Function postMessage() must match Foundry test naming convention
test (20.x, 3.11.x): contracts/Marionette.sol#L86
GC: Use Custom Errors instead of require statements
test (20.x, 3.11.x): contracts/Marionette.sol#L87
GC: Use Custom Errors instead of require statements
test (22.x, 3.12.x): contracts/Marionette.sol#L44
GC: [sender] on Event [EtherReceived] could be Indexed
test (22.x, 3.12.x): contracts/Marionette.sol#L44
GC: [amount] on Event [EtherReceived] could be Indexed
test (22.x, 3.12.x): contracts/Marionette.sol#L46
Rule is set with explicit type [var/s: uint]
test (22.x, 3.12.x): contracts/Marionette.sol#L49
GC: [receiver] on Event [EtherSent] could be Indexed
test (22.x, 3.12.x): contracts/Marionette.sol#L49
GC: [amount] on Event [EtherSent] could be Indexed
test (22.x, 3.12.x): contracts/Marionette.sol#L51
Rule is set with explicit type [var/s: uint]
test (22.x, 3.12.x): contracts/Marionette.sol#L69
Function initialize() must match Foundry test naming convention
test (22.x, 3.12.x): contracts/Marionette.sol#L78
Function postMessage() must match Foundry test naming convention
test (22.x, 3.12.x): contracts/Marionette.sol#L86
GC: Use Custom Errors instead of require statements
test (22.x, 3.12.x): contracts/Marionette.sol#L87
GC: Use Custom Errors instead of require statements
test (22.x, 3.10.x): contracts/Marionette.sol#L44
GC: [sender] on Event [EtherReceived] could be Indexed
test (22.x, 3.10.x): contracts/Marionette.sol#L44
GC: [amount] on Event [EtherReceived] could be Indexed
test (22.x, 3.10.x): contracts/Marionette.sol#L46
Rule is set with explicit type [var/s: uint]
test (22.x, 3.10.x): contracts/Marionette.sol#L49
GC: [receiver] on Event [EtherSent] could be Indexed
test (22.x, 3.10.x): contracts/Marionette.sol#L49
GC: [amount] on Event [EtherSent] could be Indexed
test (22.x, 3.10.x): contracts/Marionette.sol#L51
Rule is set with explicit type [var/s: uint]
test (22.x, 3.10.x): contracts/Marionette.sol#L69
Function initialize() must match Foundry test naming convention
test (22.x, 3.10.x): contracts/Marionette.sol#L78
Function postMessage() must match Foundry test naming convention
test (22.x, 3.10.x): contracts/Marionette.sol#L86
GC: Use Custom Errors instead of require statements
test (22.x, 3.10.x): contracts/Marionette.sol#L87
GC: Use Custom Errors instead of require statements
test (20.x, 3.9.x): contracts/Marionette.sol#L44
GC: [sender] on Event [EtherReceived] could be Indexed
test (20.x, 3.9.x): contracts/Marionette.sol#L44
GC: [amount] on Event [EtherReceived] could be Indexed
test (20.x, 3.9.x): contracts/Marionette.sol#L46
Rule is set with explicit type [var/s: uint]
test (20.x, 3.9.x): contracts/Marionette.sol#L49
GC: [receiver] on Event [EtherSent] could be Indexed
test (20.x, 3.9.x): contracts/Marionette.sol#L49
GC: [amount] on Event [EtherSent] could be Indexed
test (20.x, 3.9.x): contracts/Marionette.sol#L51
Rule is set with explicit type [var/s: uint]
test (20.x, 3.9.x): contracts/Marionette.sol#L69
Function initialize() must match Foundry test naming convention
test (20.x, 3.9.x): contracts/Marionette.sol#L78
Function postMessage() must match Foundry test naming convention
test (20.x, 3.9.x): contracts/Marionette.sol#L86
GC: Use Custom Errors instead of require statements
test (20.x, 3.9.x): contracts/Marionette.sol#L87
GC: Use Custom Errors instead of require statements