Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKALE-4983 add limit for message and test #1033

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

payvint
Copy link
Collaborator

@payvint payvint commented Feb 23, 2022

Make a limit of 1024 bytes for message

kladkogex
kladkogex previously approved these changes Feb 23, 2022
yavrsky
yavrsky previously approved these changes Feb 23, 2022
@payvint payvint dismissed stale reviews from yavrsky and sergiy-skalelabs via 7b7cf23 February 23, 2022 16:40
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1033 (e654ec1) into develop (657425e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head e654ec1 differs from pull request most recent head cce9bf7. Consider uploading reports for the commit cce9bf7 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1033      +/-   ##
===========================================
+ Coverage    87.11%   87.12%   +0.01%     
===========================================
  Files           24       24              
  Lines         1063     1064       +1     
  Branches       282      283       +1     
===========================================
+ Hits           926      927       +1     
  Misses          47       47              
  Partials        90       90              
Impacted Files Coverage Δ
proxy/contracts/MessageProxy.sol 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 657425e...cce9bf7. Read the comment docs.

kladkogex
kladkogex previously approved these changes Feb 23, 2022
yavrsky
yavrsky previously approved these changes Feb 23, 2022
@payvint payvint dismissed stale reviews from yavrsky, sergiy-skalelabs, and kladkogex via cce9bf7 February 25, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants