fix potential none reference and truncated response body when loading static files #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of only returning the first 8192 bytes in the filewrapper buffer.
snowbldr
changed the title
cooperaj
reviewed
Jan 13, 2021
| @@ -98,7 +103,7 @@ def __call__(self, event, context): | |||
|
|
|||
| response = LambdaResponse() | |||
|
|
|||
| body = next(self.wsgi_app( | |||
| body = b''.join(self.wsgi_app( | |||
There was a problem hiding this comment.
This change here fixed the issue we've been having for days.
204 response codes in Werkzeug break next as the iterator that's returned is wrong somehow. Doing this instead works just fine.
There was a problem hiding this comment.
Awesome! Glad to hear it. This had me stumped for a while too.
There was a problem hiding this comment.
Thanks for this! Fixed an issue I was having with OPTIONS requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking the test button in api gateway
I get an error
I logged out the event as json and found that headers was null
This commit adds a guard for if the headers is null, in addition initializes a few keys in the environ to an empty string to prevent key errors.
I also experience and error where all of the responses were truncated to only the first 8192 bytes when sending a static file. This is because the wsgi_app returns and iterator with an 8192k buffer, so the iterator must be exhausted to get the entire body.