Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema for report meetings and webinars #4

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

kekoav
Copy link
Contributor

@kekoav kekoav commented Sep 17, 2020

Description of change

This is a fix for #3 . The exception was being thrown due to dept property being returned as a string but schema expected integer.

Manual QA steps

Tested with my own zoom account and credentials.

Risks

  • I'm not aware of any

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

Hi @kekoav, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @kekoav!

Thank you for signing the Singer Contribution License Agreement.

@kekoav
Copy link
Contributor Author

kekoav commented Sep 28, 2020

@cmerrick let me know if you have any feedback here, would like to get this integration fixed.

@dmosorast
Copy link

Hi @kekoav! This looks to be a backwards incompatible change due to the change in data type, so we'll be including this in a 1.0.0 release of this tap, once we are able to gather up any other changes that need to be included. Thanks for the submission! If you see any other data type changes like this, we'd definitely like to wrap them all up into one release.

@allenjhyang
Copy link
Contributor

Hi @dmosorast - do you have an expected timeline for the release of 1.0.0? Thanks!

@asaf-erlich
Copy link
Contributor

I've pushed a local branch to get circle to run. It's green, will merge shortly hopefully, just double checking on the steps required for the 1.0.0 major version bump.

@asaf-erlich asaf-erlich merged commit d906fc8 into singer-io:master Mar 15, 2021
@asaf-erlich
Copy link
Contributor

I've merged, I will report back when it's released.

@asaf-erlich
Copy link
Contributor

Major version 1.0.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants