-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Memgraph #2287
Add Memgraph #2287
Conversation
Memgraph is an in-memory graph database. I'm curating Memgraph Awesome list and I believe that it is a good add-on to this list.
HI! I've fixed all of the errors reported by lint. I think that the remaining errors are false positives. I do have some links listed twice, but they appear in a different context. If this is not ok I can remove the duplicate links. |
@kgolubic We have the same situation, and we opted to |
unicorn |
Thanks for the pointers. I've managed to fix all errors and What should I do now? Can I somehow re-run the check here on GitHub? |
@sindresorhus can you please tell me what should I do now? Can I somehow re-run the check here on GitHub? Local |
Hi @kgolubic, Here are some of the points I think you can improve on readme:
Hope that helps. |
All checks have passed ok. |
There are many things not followed in the guidelines. You have also not addressed the feedback in #2287 (comment).
|
I've updated the README.md file in accordance with your comments. Thank you! |
@sindresorhus Thank you for pointing this out. I've fixed all of the mentioned issues, added the logo and description on the top, shortened the description for the main Aweosnm list, and separated descriptions of links with "-". I hope that I've covered all of the issues. |
Missing descriptions: https://github.com/kgolubic/awesome-memgraph#tools
"How Node2Vec Works - A Random Walk-Based Node Embedding Method" Descriptions should not be title-cased. |
Thank you @sindresorhus and @Lissy93. I've updated my list according to your comments. |
@kgolubic, according to this awesome-lint rule descriptions in a list should end with a punctuation mark such as dot. There are a couple of occasions where your list is missing it. For example:
Other descriptions have this problem as well. |
Bump |
Sorry for the late answer. I missed the previous comment. I've updated descriptions with dots where they were needed. |
|
I'm going to pass on this as it's taking too long and there are still many things not followed and I think the list in general could be improved. |
Ok. Thanks for all of the feedback. When I find the time, I'll improve the list and submit it again for consideration. |
(https://github.com/kgolubic/awesome-memgraph)
Memgraph is an in-memory graph database. I'm curating Memgraph Awesome list and I believe that it is a good add-on to this list.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
I've reviewed following PRs:
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.