[Monk] Mistweaver implementation #9368
Conversation
| // The Ancient Concordance buff's spell data modified number of targets hit, but the value is 1 instead of 3, so it | ||
| // is useless. We set the value manually to 3. | ||
| if ( p()->buff.ancient_concordance->check() ) | ||
| return 3; |
There was a problem hiding this comment.
It's not necessarily useless, as it may provide 2 stacks in game. Note that the effect has the "Aura Points on Client" bit set, which has to do with behaviours related to effect stacking.
Would need to perform some in game science, as it is also not logged.
| else if ( baseline.mistweaver.teachings_of_the_monastery->ok() ) | ||
| shared.teachings_of_the_monastery = baseline.mistweaver.teachings_of_the_monastery; | ||
| else | ||
| shared.teachings_of_the_monastery = spell_data_t::not_found(); |
There was a problem hiding this comment.
If you're not comfortable writing a new equivalent function to _priority that is more friendly to multiple parameter types, let me know and I can put something together.
This feels gross, even I'm generally trying to get away from shared spell pointers.
There was a problem hiding this comment.
sure, no idea how to rewrite _priority tbh
acornellier
force-pushed
the
mw
branch
5 times, most recently
from
a65ac9c
to
b2a0efc
Compare
acornellier
changed the title
HotJS effects 3, 4, and 7 duplicate the reduced CD from effect 2 for Renewing Mist, Life Cocoon, and TFT.
This reverts commit 3c2b671.
no longer changes global fallback buff and stops assertion from failing
|
The only things left to double check are TP OF working (I'm unsure if that's resolved) and whether or not all of the appropriate actions are using SP conversion properly when MW. At that point, I would consider this good to merge (even prior to SEF completion). A more flexible |
No description provided.