Added Efs #53
Added Efs #53
Conversation
|
@hoffbeam thanks for the PR ! So:
|
| @@ -8,6 +8,7 @@ | |||
| - /usr/bin/easy_install pip | |||
| - /usr/local/bin/pip install --upgrade boto3 boto awscli requests psutil {{ asg_additional_python_pip_packages }} | |||
| {{ asg_additional_user_data_bootcmd }} | |||
| {{ _efs_additional_bootcmd }} | |||
There was a problem hiding this comment.
efs is not a core module, therefore core modules shouldn't be changed. Instead, leverage the already available asg_additional_user_data_bootcmd in your playbook
| @@ -167,6 +167,24 @@ asg_launch_config_key_name: "" | |||
| asg_launch_config_instance_profile_name: "" | |||
| ``` | |||
|
|
|||
| ### EFS | |||
There was a problem hiding this comment.
this is not a core module and therefore documentation should be in the custom-instrastructure folder.
| @@ -41,3 +41,14 @@ asg_additional_security_groups: "{{ asg_additional_security_groups_env | default | |||
|
|
|||
|
|
|||
| ecs_cluster_name: "{{ cluster_name }}" | |||
|
|
|||
|
|
|||
| efs_commands: "sudo mount -t nfs4 -o nfsvers=4.1,rsize=1048576,wsize=1048576,hard,timeo=600,retrans=2 $(curl -s http://169.254.169.254/latest/meta-data/placement/availability-zone){{ efs_instance.efs.mount_point }} data" | |||
There was a problem hiding this comment.
I think this should go in the readme you will create in custom-infrastructure. This is not a core module so the examples shouldn't include extra modules
| @@ -0,0 +1,22 @@ | |||
| --- | |||
|
|
|||
| ### This is used to create efs | |||
There was a problem hiding this comment.
this has to go under your files/efs.yml
There was a problem hiding this comment.
we don't use "defaults" for custom modules
| @@ -0,0 +1,9 @@ | |||
| --- | |||
There was a problem hiding this comment.
I don't think this is needed now is it?
There is an issue in 2.3.0 of ansible which will not create the name of the efs volume. This has been fixed in 2.4.0. The volume will be created with the correct tags, just will have no name