Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades & fixes #77

Merged
merged 13 commits into from
Dec 27, 2023
Merged

Upgrades & fixes #77

merged 13 commits into from
Dec 27, 2023

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Sep 25, 2023

Current warning messages from our CI

The following actions uses node12 which is deprecated and will be forced to run on node16: LitoMore/simple-icons-release-action@b14cfca. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Changes

  • Use Node.js 20 on CI
  • Target this action runtime to Node.js 20
  • Upgrade @actions/core to the latest to drop the deprecated API usages
  • Upgrade @actions/github to the latest
  • Remove unused stash commands from .husky/pre-commit
  • Upgrade @zeit/ncc to @vercel/ncc (resolves Replace @zeit/ncc dependency by @vercel/ncc #72)
  • Fix the package entry definition in pakcage.json
  • Fix file.patch logic (Related to Release action fails simple-icons#8734 (comment))
  • Allow triggering release by workflow dispatch
  • Allow skipping release note with [skip] title prefix
  • Allow skipping release note with skip release note label
  • Add script fix-distribution-file for fixing @vercel/ncc's distribution
  • Fix Jest tests
  • Fix un-decoded HTML entities in the SVG title for release note
  • Replace Generator with async/await

Also

Release plan

I'm going to create a new major release at this repository. And it's time to switch our action URL from my repo https://github.com/LitoMore/simple-icons-release-action to this one.

References

@LitoMore LitoMore added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file refactor meta Issues or pull requests regarding the project or repository itself labels Sep 25, 2023
@adamrusted
Copy link
Member

@LitoMore - does this bring this repo in line with your release action?

@LitoMore
Copy link
Member Author

@adamrusted Yep. All changes are included.

The test part needs to be fixed. I'm checking.

@LitoMore
Copy link
Member Author

@mondeja The test has been fixed. Please review.

package.json Outdated Show resolved Hide resolved
src/create.js Show resolved Hide resolved
src/create.js Outdated Show resolved Hide resolved
Co-authored-by: Álvaro Mondéjar <[email protected]>
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @LitoMore 👍🏼

I suppose that it runs OK as haven't tested manually. The main problem of the regex not being able to detect some changes is not covered by the work here. So merging, in the future will fix that.

@mondeja mondeja merged commit a801a2a into simple-icons:master Dec 27, 2023
3 checks passed
@LitoMore LitoMore deleted the fix-release branch December 27, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request meta Issues or pull requests regarding the project or repository itself refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace @zeit/ncc dependency by @vercel/ncc
3 participants