-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades & fixes #77
Upgrades & fixes #77
Conversation
@LitoMore - does this bring this repo in line with your release action? |
@adamrusted Yep. All changes are included. The test part needs to be fixed. I'm checking. |
@mondeja The test has been fixed. Please review. |
Co-authored-by: Álvaro Mondéjar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update @LitoMore 👍🏼
I suppose that it runs OK as haven't tested manually. The main problem of the regex not being able to detect some changes is not covered by the work here. So merging, in the future will fix that.
Current warning messages from our CI
Changes
@actions/core
to the latest to drop the deprecated API usages@actions/github
to the lateststash
commands from.husky/pre-commit
@zeit/ncc
to@vercel/ncc
(resolves Replace@zeit/ncc
dependency by@vercel/ncc
#72)pakcage.json
file.patch
logic (Related to Release action fails simple-icons#8734 (comment))[skip]
title prefixskip release note
labelfix-distribution-file
for fixing@vercel/ncc
's distributionasync/await
Also
Release plan
I'm going to create a new major release at this repository. And it's time to switch our action URL from my repo https://github.com/LitoMore/simple-icons-release-action to this one.
References