Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to python3.12, django4.2 and psycopg3 #160

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

radudum10
Copy link

why

  1. Django 4.2 introduced support for psycopg3 and also a deprecation note: Support for psycopg2 is likely to be deprecated and removed at some point in the future. (https://django.readthedocs.io/en/latest/releases/4.2.html#psycopg-3-support)
  2. Users of django-sql-dashboard trying to update to psycopg3 will get a module not found error caused by the following import in views.py:
from psycopg2.extensions import quote_ident

(which is also unused, I think 😄)

what this PR aims to improve

  • addopts in pytest.ini: When I ran the tests for the first time (in docker) there was a problem with the import of pytest_use_postgresql so I've modify it.
  • Python version update to 3.12 in Docker.
  • The test packages: Django >= 4.2, psycopg >= 3.0, required python >= 3.8 (check https://www.psycopg.org/psycopg3/docs/basic/install.html#supported-systems).
  • Deleted unused imports from views.py.

Thanks for this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant