Refactor named parameters feature to allow extensibility #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor parsing of (and access to) named parameters into a single extensible
Parameter
class. The feature remains the same but the implementation is cleaner.In addition, the actual
Parameter
class used by the library may be changed using a setting namedDASHBOARD_PARAMETER_CLASS
. This allows users of the library to implement custom parameter parsings without changing the default behaviour of the libary.See issue #149 for extension ideas (
%(value)d
,%(flag:true)b
, etc).Note: I changed the
id
of theinput
HTML fields (from numericalqpX
toqp_{parameterName}
) so that these fields may be generated directly from instances of theParameter
class.All tests pass.