[chore] Fix update-deps script to not miss module upgrades #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we run go get... and go tidy in particular modules, it may affect modules that depend on it. If the dependent modules modified, running `go get ...` there fails with ``` go: updates to go.mod needed; to update it: go mod tidy ``` In order to fix that, we need to run go tidy in all the modules after updating every module
dmitryax
force-pushed
the
fix-update-deps
branch
from
06c1895 to
056a07f
Compare
pjanotti
approved these changes
Feb 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run go get... and go tidy in particular modules, it may affect modules that depend on it. If the dependent modules are modified, running
go get ...there fails withIn order to fix that, we need to run go tidy in all the modules after updating every module