Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scroll for Qr Color Picker #13968

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sagar0-0
Copy link
Contributor

@Sagar0-0 Sagar0-0 commented Feb 4, 2025

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Setting the max height to 10 times the columns minimum size. This makes sure all colors will fit on the screen.
This solution is better than not providing scroll. A better approach can be to use LazyColumn as parent of the entire UI.

@greyson-signal
Copy link
Contributor

Are you able to show a video of the bug this is fixing? We already use a LazyVerticalGrid, so I did a test where I just double the number of colors, and it scrolls fine for me without any other changes.

scrolling.mp4

@Sagar0-0
Copy link
Contributor Author

This PR is fixing the screen level Scroll, when the complete screen might not be visible in the case of Rotated Config or for Foldables.

Currently not scrollable screen:
photo_6147877567328273270_y (1)

After fix:

document_6147877566872032435.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants