Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Overlapping Conversation Banner Position for Hidden Toolbar #13962

Closed
wants to merge 1 commit into from

Conversation

Sagar0-0
Copy link
Contributor

@Sagar0-0 Sagar0-0 commented Feb 2, 2025

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Before:
photo_6122833905083075353_y

After:
Store the Toolbar height in a variable and use it in MultiSelect Mode.
photo_6122833905083075352_y

Copy link
Contributor

@greyson-signal greyson-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch on the bug. I agree it should be fixed, but in general, I try to avoid manually setting things like margins and such dynamically whenever possible. Is there something in the view hierarchy that could be fixed so that this overlap doesn't happen?

@Sagar0-0
Copy link
Contributor Author

Sagar0-0 commented Feb 3, 2025

Is there something in the view hierarchy that could be fixed

I'll explore the possibilities and update it here

@Sagar0-0
Copy link
Contributor Author

Sagar0-0 commented Feb 5, 2025

@greyson-signal Only setting the isInvisible can work instead of setting visible = false. Are there any cons for using this?

@greyson-signal
Copy link
Contributor

Changing visibility is fine, I would just like to avoid having to manually change margins in code

@Sagar0-0
Copy link
Contributor Author

Sagar0-0 commented Feb 7, 2025

Changing visibility is fine, I would just like to avoid having to manually change margins in code

This change I've proposed won't be required anymore, we can only change the visible= false to isInvisible = true. And everything will work as expected.

@greyson-signal
Copy link
Contributor

That sounds much better, will TAL when the PR is updated

@Sagar0-0 Sagar0-0 force-pushed the voice-toolbar-position branch from 29ffbb3 to e61af6e Compare February 7, 2025 19:37
@Sagar0-0
Copy link
Contributor Author

Sagar0-0 commented Feb 7, 2025

@greyson-signal there we go!
Also, I will slow down any new contributions for now and will try to make sure all my opened PRs are getting merged.

Copy link
Contributor

@greyson-signal greyson-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Will go in 7.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants