-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Overlapping Conversation Banner Position for Hidden Toolbar #13962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch on the bug. I agree it should be fixed, but in general, I try to avoid manually setting things like margins and such dynamically whenever possible. Is there something in the view hierarchy that could be fixed so that this overlap doesn't happen?
I'll explore the possibilities and update it here |
@greyson-signal Only setting the isInvisible can work instead of setting visible = false. Are there any cons for using this? |
Changing visibility is fine, I would just like to avoid having to manually change margins in code |
This change I've proposed won't be required anymore, we can only change the visible= false to isInvisible = true. And everything will work as expected. |
That sounds much better, will TAL when the PR is updated |
29ffbb3
to
e61af6e
Compare
@greyson-signal there we go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Will go in 7.34
First time contributor checklist
Contributor checklist
Fixes #1234
syntaxDescription
Before:
![photo_6122833905083075353_y](https://private-user-images.githubusercontent.com/85388413/408858793-4f23ffbc-5200-471a-8609-2270351bb583.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTE0NDksIm5iZiI6MTczOTU1MTE0OSwicGF0aCI6Ii84NTM4ODQxMy80MDg4NTg3OTMtNGYyM2ZmYmMtNTIwMC00NzFhLTg2MDktMjI3MDM1MWJiNTgzLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE2MzkwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNkZTFkN2UwNjFlMzEwMGYxMjQwMzhhMDUxNmQ2MTUzNmY3MjQ1ZmQ5NjZlNWY2NGJiODM0MjlhYzU3NWRhMzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.uTcx3sll-tXdF6hh7ayL3OlWG-mBwqlo5m7WnlJMvsQ)
After:
![photo_6122833905083075352_y](https://private-user-images.githubusercontent.com/85388413/408858804-c54c618f-0350-4a86-8934-eb4716414698.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTE0NDksIm5iZiI6MTczOTU1MTE0OSwicGF0aCI6Ii84NTM4ODQxMy80MDg4NTg4MDQtYzU0YzYxOGYtMDM1MC00YTg2LTg5MzQtZWI0NzE2NDE0Njk4LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE2MzkwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmOWRiNDFmN2E3NWQzN2JlOTQyYjA1YmEyNjNkNWFiZTI3OWM1NGNiMjQxZWI4MmEyNDczMDNiNTQ1NzgwYWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.YlDw24Xn_tItbXiOIHwBRF3gwZZu2IOhh0qlkqsNoZY)
Store the Toolbar height in a variable and use it in MultiSelect Mode.