Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Opening the Scheduled Document files #13958

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sagar0-0
Copy link
Contributor

@Sagar0-0 Sagar0-0 commented Feb 1, 2025

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

  1. Support Opening documents for Scheduled messages as there is no preview available for Documents if they are scheduled.

Why Only Documents?

  1. For Images/Video, there is a thumbnail present that indicates which item will be sent. I want to support opening these also, but Deleting the message from MediaPreview disturbs the scheduled messages. "Delete for Me" removes the scheduled message. And "Delte for Everyone" will mark the scheduled message as delete and it will still be scheduled and will be sent". And, Scheduled Sheet won't be updated after any actions from MediaPreview Activity. More refactoring will be required for supporting these.
  2. For Scheduled audio, I have already raised Fix Audio Play from Scheduled Messages #13951
  3. For docs, there is no preview available when scheduled, so user might not know which file they have sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant