Fix textStoryToggle visibility when hasSelectedMedia

[Sagar0-0]

First time contributor checklist

• I have read how to contribute to this project
• I have signed the Contributor License Agreement

Contributor checklist

• I am following the Code Style Guidelines
• I have tested my contribution on these devices:

• Device A, Android X.Y.Z
• Device B, Android Z.Y
• Virtual device W, Android Y.Y.Z

• My contribution is fully baked and ready to be merged as is
• I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

---

Description

Before:

document_6107040231842648805.mp4

After:
Observing to the latest state of selectedMedia count and updating the visibility

[greyson-signal]

I'm interested in how you're reproducing this bug, it doesn't personally happen to me.

[greyson-signal]

This is called from multiple places, and now those call sites no longer take into account whether there's selected media. Are those call sites still necesessary?

[Sagar0-0]

Yes, they are still required. We have to hide on DestinationChange(navigating to preview or gallery), and when we are back to MediaCapture, even when no media was selected, we have to update it back to visible.

[Sagar0-0]

However, this might create a problem, as now there are two sources for textStoryToggle visibility state(hasSelectedMedia and DestinationChangedListener) and it might create difficulty in testing and finding bugs. A better approach can be to move the logic to ViewModel and check the combinations there. If destinations are mediaCapture or textStore then handle the logic, else false. This way we will only expose a single LiveData of isTextStoryToggleVisible as a single source of truth.

[Sagar0-0]

I'm interested in how you're reproducing this bug, it doesn't personally happen to me.

Capture a media, Click anywhere on the Preview screen and wait for 1-2 seconds, press back button(See video). This might not show sometimes