Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve support fo sync linux/arm64 images #268

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

improve support fo sync linux/arm64 images #268

wants to merge 15 commits into from

Conversation

g-iannelli
Copy link
Contributor

CHANGES:

  • Add single_sync_v3.sh that set multi-arch to true by default and build image for platforms: linux/amd64,linux/arm64
  • Move all sync workflows into a matrix workflow
  • Removed all single module sync workflow
  • Replace sync.sh in dry run workflow with a matrix one
  • improve error logging when start docker container for buildkit during image patching

ralgozino
ralgozino requested changes Nov 8, 2024
View reviewed changes
single_sync_v3.sh Show resolved Hide resolved
single_sync_v3.sh Outdated Show resolved Hide resolved
single_sync_v3.sh Show resolved Hide resolved
single_sync_v3.sh Show resolved Hide resolved
@g-iannelli g-iannelli force-pushed the feat/product540/improve-support-for-arm64 branch from 6dfbf5e to c9e6813 Compare November 8, 2024 19:35
@g-iannelli g-iannelli force-pushed the feat/product540/improve-support-for-arm64 branch 8 times, most recently from f9686eb to cae34e9 Compare November 12, 2024 12:17
@g-iannelli g-iannelli marked this pull request as ready for review November 12, 2024 12:37
@g-iannelli g-iannelli force-pushed the feat/product540/improve-support-for-arm64 branch 6 times, most recently from bd7fa5b to 1e5bd73 Compare November 12, 2024 16:36
@nutellinoit nutellinoit removed the request for review from mbuccarello November 13, 2024 16:32
ralgozino
ralgozino previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we reviewed and tested this in pair, all seems good

🚀

@g-iannelli g-iannelli force-pushed the feat/product540/improve-support-for-arm64 branch 5 times, most recently from 8daddc2 to ae88491 Compare November 14, 2024 15:51
@g-iannelli g-iannelli force-pushed the feat/product540/improve-support-for-arm64 branch from d43b53e to 509e656 Compare November 14, 2024 16:30
@g-iannelli g-iannelli force-pushed the feat/product540/improve-support-for-arm64 branch from 509e656 to ed33e60 Compare November 14, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralgozino ralgozino ralgozino left review comments

@nutellinoit nutellinoit Awaiting requested review from nutellinoit

@sbruzzese902 sbruzzese902 Awaiting requested review from sbruzzese902

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-iannelli @ralgozino