Skip to content

Fix Bad logic to decode the column name #1413 #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

testn
Copy link
Contributor

@testn testn commented Oct 16, 2021

Introduce character_set_results tracking to ensure that we can
read the column name properly

still in the draft mode

@testn
Copy link
Contributor Author

testn commented Oct 16, 2021

@sidorares this is the first attempt trying to fix #1413. It is still rough but it should demonstrate what we can address this problem.

@testn testn force-pushed the fix-result-encoding branch from a717867 to 76b75e9 Compare October 16, 2021 02:41
@sidorares
Copy link
Owner

test/integration/connection/encoding/test-track-encodings.js test fails, not sure if your change discovered legitimate error

@testn
Copy link
Contributor Author

testn commented Oct 16, 2021

@sidorares that exposes the problem that I'm working on a fix. Basically, when you specify character_set_client, you have to encode your SQL in that encoding as well.

Introduce character_set_results tracking to ensure that we can
read the column name properly
@testn testn force-pushed the fix-result-encoding branch from 76b75e9 to 2d7fe4a Compare October 17, 2021 12:30
@wellwelwel wellwelwel added the needs rebase For internal organization purpose label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase For internal organization purpose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants