Implement Error Handling and Refactor Data Fetching in Profile Component #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @berhili098! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
berhili098
force-pushed
the
feat/error-handling-refactor-data-fetching
branch
from
a4c7501 to
7e8660c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance error handling, update data, and improve the user experience. The most important changes include the addition of an
ErrorBoundarycomponent, updates to data fetching logic, and the inclusion of a new profile.Error handling improvements:
ErrorBoundarycomponent to catch and display errors in the application. (components/ErrorBoundary.jsx)ErrorBoundaryin the_app.jsfile to ensure errors are caught and handled gracefully. (pages/_app.js)Data fetching and user experience enhancements:
fetchDatafunction to throw an error if the response is not okay and added an alert message in case of failure to load profiles. (pages/index.js) [1] [2]Data updates:
berhili098.jsonto theProfileList.jsonfile. (components/ProfileList.json)berhili098. (public/data/berhili098.json)