Enhance Makefile #20
Open
Enhance Makefile #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As usb-serial-for-android doesn't provide thier own build but propose "linking" sources upon user module build, Makefile is updated to do exactly this. Additionally fixed paths of resources in the packaged jar file: resources are now packed directy into the root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings few changes to the Makefile, allowing users to rebuild the library from scratch after the clone:
usb-serial-for-androidsubmodule is now initialized automatically (previously had to be initialized manually withgit submodule init && git submodule update, before launchingmake init).ArduinoFirmata-Androidandusb-serial-for-android, which ensures that compiler will find necessary depdendencies, and thatArduinoFirmata-Androidis compiled against sameusb-serial-for-androidversion as the one which will be then assembled (see below).ArduinoFirmata-Androiditself, and forusb-serial-for-android. This is necessary because it turns out thatusb-serial-for-androidjars are no longer updated/distributed for plain download, and project's README actually recommends to "link" its sources upon build directly - what this update effectively does.P.S. I think though that a more proper way to manage the build process would be to implement a Gradle project, which will allow correct build on all platforms, and will allow managing
usb-serial-for-androidproperly (as a dependency). This update however is a quick change to enable easier assembling of the libraries, while not changing the process conceptually.