fix: add missing super.disconnectCallback() calls (#1564)

shoelace-style · Sep 14, 2023 · 1d28e1b · 1d28e1b
1 parent 3b77c3b
commit 1d28e1b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/src/components/details/details.component.ts b/src/components/details/details.component.ts
@@ -87,6 +87,7 @@ export default class SlDetails extends ShoelaceElement {
   }
 
   disconnectedCallback() {
+    super.disconnectedCallback();
     this.detailsObserver.disconnect();
   }
 

diff --git a/src/components/mutation-observer/mutation-observer.component.ts b/src/components/mutation-observer/mutation-observer.component.ts
@@ -52,6 +52,7 @@ export default class SlMutationObserver extends ShoelaceElement {
   }
 
   disconnectedCallback() {
+    super.disconnectedCallback();
     this.stopObserver();
   }
 

diff --git a/src/components/popup/popup.component.ts b/src/components/popup/popup.component.ts
@@ -198,6 +198,7 @@ export default class SlPopup extends ShoelaceElement {
   }
 
   disconnectedCallback() {
+    super.disconnectedCallback();
     this.stop();
   }
 

diff --git a/src/components/tab-group/tab-group.component.ts b/src/components/tab-group/tab-group.component.ts
@@ -117,6 +117,7 @@ export default class SlTabGroup extends ShoelaceElement {
   }
 
   disconnectedCallback() {
+    super.disconnectedCallback();
     this.mutationObserver.disconnect();
     this.resizeObserver.unobserve(this.nav);
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -87,6 +87,7 @@ export default class SlDetails extends ShoelaceElement { @@
       }
       disconnectedCallback() {
+        super.disconnectedCallback();
         this.detailsObserver.disconnect();
       }
@@ Expand Down @@