-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unix socket support for prometheus #128
Conversation
cc @shizunge do you mind taking a look? |
cc @Bananz0 @JeDaYoshi do you mind taking a look? |
I'm not part of the project, so I can't act on it. |
gotcha! appreciate the fast response. i see you have contributed here before though - do you have any suggestions or criticisms for this change? |
cc @olofvndrhr do you mind taking a look? |
I will take a look at this at Sept 19 or 20. |
any updates on this? |
626155e
to
c3ae83d
Compare
addressed the comments from my side |
this PR allows for listening on a Unix domain socket for prometheus metrics by prefixing the path with
unix:
also open to alternative prefixes like
unix/
(which is what caddy uses)some of this approach can probably be reused for #112
example usage:
starting endlessh-go
try connecting to generate some metrics
get the metrics