Our own Tools struct #5
Merged
+639
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th all Qwen2.5 models
atdrendel
reviewed
Feb 28, 2025
|
|
||
| let expectedTool1 = WeatherTool.getCurrentWeather(.init( | ||
| location: "Paris, France", | ||
| unit: .celsius |
There was a problem hiding this comment.
@myobie Interestingly, Qwen 2.5 7B usually seems to return Celsius for this question. Granted, it makes sense because France uses Celsius. The smaller version of this model usually returns Fahrenheit, though, maybe because it's not smart enough to think about what measurement people in the city being asked about uses. Of course, that's just a guess.
atdrendel
reviewed
Feb 28, 2025
| "role": "system", | ||
| "content": "You are weather fetching assistant. Your only purpose is to fetch weather data.", | ||
| ], | ||
| ["role": "system", "content": "The user prefers F°."], |
There was a problem hiding this comment.
@myobie I swapped Fahrenheit for Celsius here just to see if 7B listens to us. It seems to most of the time.
atdrendel
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to specify tools.