Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rate changed 1% negative threshold #8933

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gomesalexandre
Copy link
Contributor

Description

Ensures there's 1% (as 100bps for the sake of making things flexible enough in case we want to make that number more granular) bps threshold to display the rate changed modal.

Issue (if applicable)

closes #8911

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low/None

Testing

  • Ensure you don't see the rate changed modal with less than 1% downside (and still don't see it in case of any upside)

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/c80eb15a-754d-42d3-94de-e1a4a06df5a8

@gomesalexandre gomesalexandre requested a review from a team as a code owner February 25, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit decimals on new rate modal so if there is $0.00 price change the modal doesn't show
1 participant