Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds typing to the query params of the routes in position details, which exposes the actual issue:
rewardAddress
(andcontractAddress
) is not guaranteed to be defined.Guard against that so we don't crash:
Side note, we should be typing all of these stringified query params, but the DeFi section is already a mess of duplicate spaghetti and it's probably best to just burn it all.
Issue (if applicable)
Closes #8910
Risk
Low
Interaction with "Each" positions.
Testing
Engineering
Operations
Screenshots (if applicable)
This branch, no "Manage" button:
Production, manage button of death: