Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit decimals on new rate modal so if there is $0.00 price change the modal doesn't show #8911

Open
2 tasks done
MBMaria opened this issue Feb 20, 2025 · 1 comment · May be fixed by #8933
Open
2 tasks done

Limit decimals on new rate modal so if there is $0.00 price change the modal doesn't show #8911

MBMaria opened this issue Feb 20, 2025 · 1 comment · May be fixed by #8933
Assignees
Labels
needs product Requires product input before bounty polish Just a little love needed.

Comments

@MBMaria
Copy link

MBMaria commented Feb 20, 2025

Overview

When doing a trade that has a price change of a very small decimal percent which equates to a $0.00 change, it shows the rate change box and says a $0.00 difference... Can we limit the decimal points so that a $0.00 change does not trigger the new price box?

References and additional details

Image

Acceptance Criteria

limit the decimal points so that a $0.00 change does not trigger the new price box

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added the polish Just a little love needed. label Feb 20, 2025
@0xApotheosis 0xApotheosis added the needs product Requires product input before bounty label Feb 20, 2025
@twblack88
Copy link
Contributor

twblack88 commented Feb 24, 2025

💯 @MBMaria I think a sane amount is probably 1%

More advanced would be custom for crypto <> crypto and then .1% for stables<>crypto. We can make a subtask for that and create a user setting i'd reckon. Since we're revamping that for quotes we might as well include "acceptable quote change"

@gomesalexandre gomesalexandre self-assigned this Feb 25, 2025
@gomesalexandre gomesalexandre linked a pull request Feb 25, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs product Requires product input before bounty polish Just a little love needed.
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants