Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update deps #86

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: Update deps #86

merged 1 commit into from
Dec 11, 2024

Conversation

joeyparrish
Copy link
Member

The old deps were in conflict. This fixes it by updating to the latest jasmine-browser-runner, and removing the explicit jasmine-core dep (which is covered by jasmine-browser-runner, but with a specific version that is compatible with jasmine-browser-runner).

The old deps were in conflict.  This fixes it by updating to the latest jasmine-browser-runner, and removing the explicit jasmine-core dep (which is covered by jasmine-browser-runner, but with a specific version that is compatible with jasmine-browser-runner).
Copy link
Contributor

@xhwang-chromium xhwang-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeyparrish joeyparrish merged commit 3de3e4c into shaka-project:main Dec 11, 2024
5 checks passed
@joeyparrish joeyparrish deleted the deps branch December 11, 2024 17:11
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Feb 9, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants