Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header #11

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Header #11

wants to merge 7 commits into from

Conversation

praneershrest
Copy link

No description provided.

@alikhamesy
Copy link
Member

alikhamesy commented Sep 27, 2020

image
Clicked on links (<a> tags) are not styled properly, I think you need to manually add color: #ffffff to the <a> tag.

Copy link
Member

@alikhamesy alikhamesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im sorry for the CSS Spam lol

src/css/Header.module.css Outdated Show resolved Hide resolved
mandate="Engage • Empower • Innovate"
mission={(
<>
<b>SFU Surge</b> is an all-inclusive organization to promote
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These <b> tags should have font-weight:600 according to designs. I Suggest that inside of Header.module.css. you add {the paragraph classname} b { font-weight:600 } to achieve this.

src/css/Header.module.css Outdated Show resolved Hide resolved
src/components/Header.js Outdated Show resolved Hide resolved
src/css/Homepage.module.css Show resolved Hide resolved
src/css/Homepage.module.css Outdated Show resolved Hide resolved
src/css/Homepage.module.css Outdated Show resolved Hide resolved
src/css/Homepage.module.css Outdated Show resolved Hide resolved
@@ -38,6 +38,7 @@

.title {
width: 60%;
color: #ffffff;
font-size: 30px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fontsize

src/css/Homepage.module.css Outdated Show resolved Hide resolved
Copy link
Member

@alikhamesy alikhamesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict with dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants