-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEWLINE: added eol for different environments and updated dependencies #30
base: main
Are you sure you want to change the base?
Conversation
@@ -12,6 +12,6 @@ | |||
"skipLibCheck": true, | |||
"declaration": true, | |||
"declarationDir": "./", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jetzt ist die index.d.ts
ja weg, aber hier wird das wieder dorthin gebaut. Ich würde das wie folgt ändern, um die Typen neben dem Javascript zu haben:
"declarationDir": "./", | |
"declarationDir": "./dist", |
In der package.json
dann auch noch Z. 6ff entsprechend mit anpassen:
"main": "dist/index.js",
"types": "dist/index.d.ts",
"files": [
"dist/**/*"
],
Dann liegt da alles beisammen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dann wird das aber im package nicht mehr erkannt. Die index.d.ts muss im Root liegen wenn ich nicht irre.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dafür ja das Feld types
in der package.json. Das ist aktuell: types: "index.d.ts"
, wenn man das auch (entsprechend der Konfiguration für Typescript) auf types: "dist/index.d.ts"
ändert, werden die Typen auch in referenzierenden Packages entsprechend gefunden.
Kudos, SonarCloud Quality Gate passed!
|
No description provided.