Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWLINE: added eol for different environments and updated dependencies #30

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

sevensc
Copy link
Owner

@sevensc sevensc commented Mar 14, 2023

No description provided.

@sevensc sevensc requested a review from aequi42 March 14, 2023 10:53
@sevensc sevensc self-assigned this Mar 14, 2023
@sevensc sevensc changed the title NEWLINE: added eol for difereent envoronment NEWLINE: added eol for different environments and updated dependencies Mar 14, 2023
@sevensc sevensc marked this pull request as draft March 15, 2023 09:50
@aequi42
Copy link
Collaborator

aequi42 commented Mar 15, 2023

#21

@sevensc sevensc marked this pull request as ready for review March 16, 2023 07:48
@@ -12,6 +12,6 @@
"skipLibCheck": true,
"declaration": true,
"declarationDir": "./",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jetzt ist die index.d.ts ja weg, aber hier wird das wieder dorthin gebaut. Ich würde das wie folgt ändern, um die Typen neben dem Javascript zu haben:

Suggested change
"declarationDir": "./",
"declarationDir": "./dist",

In der package.json dann auch noch Z. 6ff entsprechend mit anpassen:

  "main": "dist/index.js",
  "types": "dist/index.d.ts",
  "files": [
    "dist/**/*"
],

Dann liegt da alles beisammen

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dann wird das aber im package nicht mehr erkannt. Die index.d.ts muss im Root liegen wenn ich nicht irre.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dafür ja das Feld types in der package.json. Das ist aktuell: types: "index.d.ts", wenn man das auch (entsprechend der Konfiguration für Typescript) auf types: "dist/index.d.ts" ändert, werden die Typen auch in referenzierenden Packages entsprechend gefunden.

https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package

@sevensc sevensc marked this pull request as draft March 16, 2023 09:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants