Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update react monorepo to v19 (major) #414

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3,684 −3,357
Open

fix(deps): update react monorepo to v19 (major) #414

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a89a19
fix(deps): update react monorepo to v19
renovate[bot] Feb 21, 2025
3576427
fix: components for react 19
setchy Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Loading
Loading status checks…
fix(deps): update react monorepo to v19
@renovate
renovate[bot] authored Feb 21, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 7a89a1968e4cb16d6825752bd8f0005a2bd1d222
8 changes: 4 additions & 4 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -118,8 +118,8 @@
"electron-log": "5.3.0",
"electron-updater": "6.3.9",
"menubar": "9.5.1",
"react": "18.3.1",
"react-dom": "18.3.1",
"react": "19.0.0",
"react-dom": "19.0.0",
"react-router-dom": "7.2.0",
"update-electron-app": "3.1.1"
},
@@ -153,8 +153,8 @@
"@testing-library/react": "16.2.0",
"@types/jest": "29.5.14",
"@types/node": "22.13.4",
"@types/react": "18.3.18",
"@types/react-dom": "18.3.5",
"@types/react": "19.0.8",
"@types/react-dom": "19.0.3",
"@types/react-router-dom": "5.3.3",
"autoprefixer": "10.4.20",
"axios": "1.7.9",
741 changes: 365 additions & 376 deletions pnpm-lock.yaml
View file

Large diffs are not rendered by default.

Unchanged files with check annotations Beta

View file
src/renderer/components/notifications/AccountNotifications.tsx
return (
<Stack>
<Box
onClick={toggleAccountNotifications}

Check failure on line 117 in src/renderer/components/notifications/AccountNotifications.tsx

GitHub Actions / Tests / Run Tests 

Type '{ children: Element; onClick: () => void; paddingInline: "space.100"; paddingBlock: "space.050"; backgroundColor: "color.background.accent.red.subtler" | "color.background.accent.blue.subtler" | "color.background.accent.gray.subtler"; xcss: { ...; }; }' is not assignable to type 'IntrinsicAttributes & Omit<{}, "className" | "as"> & BasePrimitiveProps & StyleProp & BaseBoxProps<CustomElementType<any>>'.
paddingInline="space.100"
paddingBlock="space.050"
backgroundColor={
View file
src/renderer/components/notifications/NotificationRow.tsx
<Box padding="space.100">
<Inline space={spaceBetweenSections} alignBlock="center">
<Inline space={spaceBetweenSections} grow="fill" alignBlock="start">
<Box id="notification-avatar">

Check failure on line 72 in src/renderer/components/notifications/NotificationRow.tsx

GitHub Actions / Tests / Run Tests 

Type '{ children: Element; id: string; }' is not assignable to type 'IntrinsicAttributes & Omit<{}, "className" | "as"> & BasePrimitiveProps & StyleProp & BaseBoxProps<CustomElementType<any>>'.
<Stack space="space.050" alignInline="center">
<Tooltip
content={notification.actor.displayName}
<Inline grow="fill">
<Box
id="notification-details"

Check failure on line 92 in src/renderer/components/notifications/NotificationRow.tsx

GitHub Actions / Tests / Run Tests 

Type '{ children: Element; id: string; onClick: () => void; testId: string; }' is not assignable to type 'IntrinsicAttributes & Omit<{}, "className" | "as"> & BasePrimitiveProps & StyleProp & BaseBoxProps<CustomElementType<any>>'.
onClick={handleNotificationInteraction}
testId="notification-details"
>
<div className="cursor-pointer">
<Stack space="space.025">
<Box id="notification-title">

Check failure on line 98 in src/renderer/components/notifications/NotificationRow.tsx

GitHub Actions / Tests / Run Tests 

Type '{ children: (string | Element)[]; id: string; }' is not assignable to type 'IntrinsicAttributes & Omit<{}, "className" | "as"> & BasePrimitiveProps & StyleProp & BaseBoxProps<CustomElementType<any>>'.
<Text>{notification.message}</Text>
&nbsp;&nbsp;
<Text size="small" as="em" align="end">
{updatedAt}
</Text>
</Box>
<Box id="notification-metadata">

Check failure on line 105 in src/renderer/components/notifications/NotificationRow.tsx

GitHub Actions / Tests / Run Tests 

Type '{ children: Element[]; id: string; }' is not assignable to type 'IntrinsicAttributes & Omit<{}, "className" | "as"> & BasePrimitiveProps & StyleProp & BaseBoxProps<CustomElementType<any>>'.
<Box id="notification-entity">

Check failure on line 106 in src/renderer/components/notifications/NotificationRow.tsx

GitHub Actions / Tests / Run Tests 

Type '{ children: Element; id: string; }' is not assignable to type 'IntrinsicAttributes & Omit<{}, "className" | "as"> & BasePrimitiveProps & StyleProp & BaseBoxProps<CustomElementType<any>>'.
<Inline space="space.050">
<Avatar
name={notification.entity.title}
</Inline>
</Box>
<Box
id="notification-product"

Check failure on line 118 in src/renderer/components/notifications/NotificationRow.tsx

GitHub Actions / Tests / Run Tests 

Type '{ children: Element; id: string; paddingInlineStart: "space.025"; }' is not assignable to type 'IntrinsicAttributes & Omit<{}, "className" | "as"> & BasePrimitiveProps & StyleProp & BaseBoxProps<CustomElementType<any>>'.
paddingInlineStart="space.025"
>
<Inline space="space.075">
</Inline>
</Inline>
<Box id="notification-actions">

Check failure on line 138 in src/renderer/components/notifications/NotificationRow.tsx

GitHub Actions / Tests / Run Tests 

Type '{ children: Element; id: string; }' is not assignable to type 'IntrinsicAttributes & Omit<{}, "className" | "as"> & BasePrimitiveProps & StyleProp & BaseBoxProps<CustomElementType<any>>'.
{!animateExit &&
(isNotificationUnread ? (
<Tooltip content="Mark as read" position="left">
View file
src/renderer/components/notifications/ProductNotifications.tsx
return (
<Stack>
<Box
onClick={toggleProductNotifications}

Check failure on line 51 in src/renderer/components/notifications/ProductNotifications.tsx

GitHub Actions / Tests / Run Tests 

Type '{ children: Element; onClick: () => void; paddingInlineStart: "space.050"; paddingInlineEnd: "space.100"; paddingBlock: "space.050"; backgroundColor: "color.background.accent.blue.subtlest" | "color.background.accent.gray.subtlest"; xcss: { ...; }; }' is not assignable to type 'IntrinsicAttributes & Omit<{}, "className" | "as"> & BasePrimitiveProps & StyleProp & BaseBoxProps<CustomElementType<any>>'.
paddingInlineStart="space.050"
paddingInlineEnd="space.100"
paddingBlock="space.050"
View file
src/renderer/hooks/useInterval.ts
// Thanks to https://overreacted.io/making-setinterval-declarative-with-react-hooks/
export const useInterval = (callback, delay) => {
const savedCallback = useRef();

Check failure on line 5 in src/renderer/hooks/useInterval.ts

GitHub Actions / Tests / Run Tests 

Expected 1 arguments, but got 0.
// Remember the latest callback.
useEffect(() => {