docs: base url relative join #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
weihanglo
approved these changes
Dec 28, 2024
Signed-off-by: tison <[email protected]>
|
This should close #333. |
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
=======================================
Coverage ? 79.87%
=======================================
Files ? 24
Lines ? 4327
Branches ? 0
=======================================
Hits ? 3456
Misses ? 871
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
valenting
approved these changes
Apr 12, 2025
|
I do think some prose would also be warranted here, explaining this issue. Perhaps this can be done holistically with #934, having each function get clear documentation on behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this case today and have to check the behavior by myself.
A doctest would be helpful for downstream users to get the behavior quickly.