Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

增加格式规范 #265

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

增加格式规范 #265

wants to merge 3 commits into from
+55 −1

Conversation

chengwhynot
Copy link
Contributor

拷贝了部分Istio的格式规范

@chengwhynot
Create styling-guide.md
924cabd 
先把Istio的style guide抄过来一版
@chengwhynot
Update styling-guide.md
55627d5
@chengwhynot
Update README.md
f537fc9 
在Readme中增加格式规范的链接
@auto-assign auto-assign bot requested a review from SataQiu April 29, 2019 02:14
@auto-comment
Copy link

auto-comment bot commented Apr 29, 2019

Thank your for raising your pull request. We will review it as soon as possible.
😆

@chengwhynot
Copy link
Contributor Author

需不需要在规范前面或后面致谢下Istio？

@haiker2011
Copy link
Member

规范方面的事情，最好 @rootsongjc 也review，最终同意

@haiker2011
Copy link
Member

@Garboy 可以加上致谢。最好再讨论一下，把相关的格式规范都添加完整，以后自动化脚本可能也要参考这些规范。

@rootsongjc rootsongjc added WIP Work in progres do-not-merge 不要合并 labels Apr 29, 2019
@rootsongjc
Copy link
Member

这个 PR 先不要合并，我们不断在这里评论补充。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu Awaiting requested review from SataQiu

@rootsongjc rootsongjc Awaiting requested review from rootsongjc

Assignees

@loverto loverto

Labels
do-not-merge 不要合并 WIP Work in progres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chengwhynot @haiker2011 @rootsongjc @loverto