Fix/oracle dto types (GalaChain#423)

* finalize Oracle Cross-rate price assertions

support bridge out, destination chain fee transaction
calculations in tokens that aren't directly priced in
GALA, using a common cross-rate exchange rate denominated
in a widely used token.

* fix oracle dtos and types for cross rate price assertions

chain-api/src/types/oracle.ts

@@ -374,18 +374,20 @@ export class OracleBridgeFeeAssertionDto extends ChainCallDTO {
   @JSONSchema({
     description: "Exchange Rate Price Assertion used to calculate Gas Fee"
   })
+  @IsOptional()
   @ValidateIf((assertion) => !!assertion.galaExchangeCrossRate)
   @ValidateNested()
   @Type(() => OraclePriceAssertionDto)
-  public galaExchangeRate: OraclePriceAssertionDto;
+  public galaExchangeRate?: OraclePriceAssertionDto;
 
   @JSONSchema({
     description: "Cross-Rate Exchange Rate used to calculate Gas Fee"
   })
+  @IsOptional()
   @ValidateIf((assertion) => !!assertion.galaExchangeRate)
   @ValidateNested()
-  @Type(() => OraclePriceCrossRateAssertion)
-  public galaExchangeCrossRate?: OraclePriceCrossRateAssertion;
+  @Type(() => OraclePriceCrossRateAssertionDto)
+  public galaExchangeCrossRate?: OraclePriceCrossRateAssertionDto;
 
   @JSONSchema({
     description:

chaincode/src/fees/feeGateImplementations.ts

@@ -368,10 +368,22 @@ export async function requestTokenBridgeOutFeeGate(ctx: GalaChainContext, dto: R
       txid
     });
   } else if (galaExchangeCrossRate !== undefined) {
+    const baseTokenCrossRate: OraclePriceAssertion = await createValidChainObject(OraclePriceAssertion, {
+      ...galaExchangeCrossRate.baseTokenCrossRate,
+      txid
+    });
+
+    const quoteTokenCrossRate: OraclePriceAssertion = await createValidChainObject(OraclePriceAssertion, {
+      ...galaExchangeCrossRate.quoteTokenCrossRate,
+      txid
+    });
+
     bridgeFeeAssertionRecord.galaExchangeCrossRate = await createValidChainObject(
       OraclePriceCrossRateAssertion,
       {
         ...galaExchangeCrossRate,
+        baseTokenCrossRate,
+        quoteTokenCrossRate,
         txid
       }
     );