Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLNP-6284] feat: require only camera permission when using camera feature #228

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Feb 6, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-6284](https://sendbird.atlassian.net/browse/CLNP-6284)

Description Of Changes

Require only camera permission when using camera feature(Take a video, Take a photo)

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@OnestarLee OnestarLee changed the title feat: require only camera permission when using camera feature [CLNP-6284] feat: require only camera permission when using camera feature Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 11.53%. Comparing base (01bcefd) to head (0ccf037).

Files with missing lines Patch % Lines
...ct-native/src/platform/createFileService.native.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   11.53%   11.53%   -0.01%     
==========================================
  Files         357      357              
  Lines        8460     8463       +3     
  Branches     2385     2249     -136     
==========================================
  Hits          976      976              
- Misses       7409     7486      +77     
+ Partials       75        1      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OnestarLee OnestarLee closed this Feb 6, 2025
@OnestarLee OnestarLee force-pushed the feat/camera-permission-check-only branch from a7b0964 to 01bcefd Compare February 6, 2025 05:50
@OnestarLee OnestarLee reopened this Feb 6, 2025
@OnestarLee OnestarLee requested a review from bang9 February 6, 2025 06:23
Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@OnestarLee OnestarLee added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit f470079 Feb 6, 2025
7 checks passed
@OnestarLee OnestarLee deleted the feat/camera-permission-check-only branch February 6, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants